Skip to content

gh-154059: Fix Tachyon flame graph time units#154036

Open
pablogsal wants to merge 5 commits into
python:mainfrom
pablogsal:agent/gh-154033-tachyon-flamegraph-time-units
Open

gh-154059: Fix Tachyon flame graph time units#154036
pablogsal wants to merge 5 commits into
python:mainfrom
pablogsal:agent/gh-154033-tachyon-flamegraph-time-units

Conversation

@pablogsal

@pablogsal pablogsal commented Jul 18, 2026

Copy link
Copy Markdown
Member

@pablogsal pablogsal added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 18, 2026
@pablogsal
pablogsal marked this pull request as ready for review July 18, 2026 23:49
@pablogsal pablogsal changed the title gh-154033: Fix Tachyon flame graph time units gh-154059: Fix Tachyon flame graph time units Jul 19, 2026
@pablogsal

Copy link
Copy Markdown
Member Author

CC: @lkollar

Comment thread Lib/profiling/sampling/_flamegraph_assets/flamegraph.js Outdated
Co-authored-by: László Kiss Kollár <kiss.kollar.laszlo@gmail.com>
Comment thread Lib/profiling/sampling/_flamegraph_assets/flamegraph.js
@python-cla-bot

This comment was marked as outdated.

@ivonastojanovic
ivonastojanovic force-pushed the agent/gh-154033-tachyon-flamegraph-time-units branch from a026674 to cd8f412 Compare July 21, 2026 14:48

@lkollar lkollar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core review needs backport to 3.15 pre-release feature fixes, bugs and security fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tachyon flamegraph: Total time displayed is affected by sampling rate

3 participants